[PATCH v2] ufs: ti-j721e: Correct error detection
    Anshul Dalal 
    anshuld at ti.com
       
    Tue Oct  7 14:14:19 CEST 2025
    
    
  
On Tue Oct 7, 2025 at 5:12 PM IST, Andrew Goodbody wrote:
> In ti_j721e_ufs_probe there is a call to clk_get_rate but the code after
> that attempts to detect an error from that call incorrectly uses
> IS_ERR_VALUE.  Instead the test should just be for regular error codes.
> The call returns an unsigned long so that needs to be cast to a signed type
> first of all.
>
> This issue was found by Smatch.
>
> Signed-off-by: Andrew Goodbody <andrew.goodbody at linaro.org>
Reviewed-by: Anshul Dalal <anshuld at ti.com>
Regards,
Anshul
    
    
More information about the U-Boot
mailing list