[PATCH RFC v3 2/8] mmc: meson_gx_mmc: add minimal non-DM driver
    Ferass El Hafidi 
    funderscore at postmarketos.org
       
    Wed Oct  8 15:55:22 CEST 2025
    
    
  
On Wed Oct 8, 2025 at 1:33 PM UTC, Neil Armstrong wrote:
> <...>
>> @@ -67,7 +69,7 @@ static void meson_mmc_config_clock(struct mmc *mmc)
>>   	 * Other SoCs use CLK_CO_PHASE_180 by default.
>>   	 * It needs to find what is a proper value about each SoCs.
>>   	 */
>> -	if (meson_gx_mmc_is_compatible(mmc->dev, MMC_COMPATIBLE_SM1))
>> +	if (IS_ENABLED(CONFIG_MESON_SM))
>
> I'm not a fan of that, technically while we keep the socs separated the
> driver should be generic and not rely on the soc config.
>
> I'k ok to have it in non-DM, but in DM it should still use meson_gx_mmc_is_compatible().
>
I'll drop this for next revision then. Shouldn't change anything
anyway, given SPL uses non-DM.
Best regards,
Ferass
    
    
More information about the U-Boot
mailing list