[PATCH v4 4/4] boot: Move preparing bootdev into a function

Tom Rini trini at konsulko.com
Thu Oct 9 19:35:22 CEST 2025


On Thu, Oct 09, 2025 at 03:29:55AM -0600, Simon Glass wrote:

> The code at the end of iter_inc() is already somewhat tortuous. Before
> making it worse, move it into a function.

This is not a great commit message. Taking a look at v2 as a whole, the
reason to extract this logic from the end of iter_inc is because you
will be checking it in multiple places. That is a good reason to move
the code. Adding another 5 lines of code (a single if test) alone would
not be.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20251009/83b266be/attachment-0001.sig>


More information about the U-Boot mailing list