[PATCH] efi_loader: Use ESRT_FW_TYPE_SYSTEMFIRMWARE instead of ESRT_FW_TYPE_UNKNOWN

[Heinrich Schuchardt]

On 10/10/25 12:59, Ilias Apalodimas wrote:
> We currently set the firmware image type to ESRT_FW_TYPE_UNKNOWN.
> 
> The spec defines the following:
> ESRT_FW_TYPE_UNKNOWN 0x00000000
> ESRT_FW_TYPE_SYSTEMFIRMWARE 0x00000001
> ESRT_FW_TYPE_DEVICEFIRMWARE 0x00000002
> ESRT_FW_TYPE_UEFIDRIVER 0x00000003
> 
> Since we don't support updating DEVICEFIRMWARE or UEFIDRIVER types,
> let's switch over to SYSTEMFIRMWARE which seems more appropriate.
> 
> Suggested-by: Michal Simek <michal.simek at amd.com>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>

Reviewed-by: Heinrich Schuchardt <xypron.glpk at gmx.de>

> ---
>   lib/efi_loader/efi_esrt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/efi_loader/efi_esrt.c b/lib/efi_loader/efi_esrt.c
> index e235c8fe91c6..3cc389eb11cd 100644
> --- a/lib/efi_loader/efi_esrt.c
> +++ b/lib/efi_loader/efi_esrt.c
> @@ -236,7 +236,7 @@ efi_status_t efi_esrt_add_from_fmp(struct efi_firmware_management_protocol *fmp)
>   	 * TODO: set the field image_type depending on the FW image type
>   	 * defined in a platform basis.
>   	 */
> -	u32 image_type = ESRT_FW_TYPE_UNKNOWN;
> +	u32 image_type = ESRT_FW_TYPE_SYSTEMFIRMWARE;
>   
>   	/* TODO: set the capsule flags as a function of the FW image type. */
>   	u32 flags = 0;