[PATCH v4 2/4] boot: Move obtaining the label into a common file

[Simon Glass]

Hi Tom,

On Fri, 10 Oct 2025 at 15:39, Tom Rini <trini at konsulko.com> wrote:
>
> On Fri, Oct 10, 2025 at 04:11:51PM +0200, Mattijs Korpershoek wrote:
> > On Fri, Oct 10, 2025 at 11:35, Simon Glass <sjg at chromium.org> wrote:
> >
> > > Hi Tom,
> > >
> > > On Thu, 9 Oct 2025 at 18:24, Tom Rini <trini at konsulko.com> wrote:
> > >>
> > >> On Thu, Oct 09, 2025 at 03:29:53AM -0600, Simon Glass wrote:
> > >>
> > >> > The 'bootflow list' command supports looking at the EFI device-path when
> > >> > available. Move this piece into a common function so it can be used
> > >> > elsewhere.
> > >>
> > >> The point of this was to enable the show_bootflow->bootflow_show chnage,
> > >> so should be dropped.
> > >
> > > OK.
> > >
> > >>
> > >> > Use 'usb' instead of 'usb_mass_storage' for usb so that it fits in the
> > >> > column space.
> > >> >
> > >> > This updates the output from 'bootflow list'.
> > >>
> > >> And this is unrelated and should be its own patch. Wikipedia says USB
> > >> MSC or UMS are the common short forms for USB Mass Storage devices, and
> > >> we should use one of them to have the output be more precise (since we
> > >> support USB networking devices for example).
> > >
> > > Ok I can move it into its own patch.
> > >
> > > Are you wanting this to say 'ums' instead of 'usb' ? Will anyone know
> > > what that means?
> >
> > Search for 'ums' gives the following U-Boot documentation:
> >
> > https://docs.u-boot.org/en/latest/usage/cmd/ums.html#ums-command
> >
> > Where the acronym is documented.
> > This is also the acronym used by the cmd (to configure usb gadget as USB
> > Mass Storage).
> >
> > So I'd say it's a reasonable acronym
>
> Thanks.

OK so I'll update this to show 'ums'.

>
> > > Re the second point, at least in U-Boot a USB Ethernet device shows as
> > > 'ethernet', i.e. the interface doesn't matter. We don't have logic to
> > > look a level deeper, at present.
>
> And this is unfortunate and confusing then because it'd be really good
> to know if I'm talking about the USB ethernet I plugged in or the
> ethernet port on the board. Made more confusing in turn by the platforms
> (more historical than modern I *think*) where that ethernet port on the
> SBC itself is wired in via USB.

A user can only tell that with something like 'dm tree' today. Perhaps
this is outside of the scope of this patch, but what would you like it
to show if it is USB Ethernet? Are you asking for code which checks
for this and shows 'usb_ether' or similar?

I still know of boards which use on-board USB for Ethernet, but more
historical as you say.

Regards,
Simon