[PATCH v2 3/7] doc: make pdfdocs: Add pip install -r test/py/requirements.txt to the list of needed steps

Tom Rini trini at konsulko.com
Fri Oct 17 16:05:15 CEST 2025


On Fri, Oct 17, 2025 at 03:50:44PM +0200, Heinrich Schuchardt wrote:
> On 10/6/25 00:10, Adriano Carvalho wrote:
> > As requested, I added this step to all doc targets.
> 
> This change looks wrong to me.
> 
> Everything needed to build the documentation should be in
> doc/sphinx/requirements.txt.
> 
> Everything needed to run tests should be in test/py/requirements.txt.
> 
> If there is an overlap that is fine. But, please, abstain from confusing the
> two.
> 
> Please, add missing dependencies to doc/sphinx/requirements.txt.
> 
> > 
> > If I don't do this, this is what I get with
> > docker.io/trini/u-boot-gitlab-ci-runner:jammy-20250714-25Jul2025:
> > 
> > uboot at 35c89b9ab70e:~/u-boot$ make pdfdocs
> > [...]
> > WARNING: autodoc: failed to import module 'test_bind'; the following exception was raised:
> > No module named 'pytest' [autodoc.import_object]
> 
> Why should pytest be needed to build documentation?

Because the pytest documentation requires it, ie
doc/develop/pytest/test_*.rst.

Can we just list pytest in both requirements.txt, or will it become
annoying to have to update two places each time? I'm not sure.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20251017/c4c3786a/attachment.sig>


More information about the U-Boot mailing list