[RFC PATCH 2/2] pinctrl: exynos: add exynos5250 driver

[Henrik Grimler]

Hi Lukas,

On Tue, Oct 14, 2025 at 01:14:02AM +0200, Lukas Timmermann wrote:
> Adds the needed files for using the new pinctrl driver with exynos5250
> SoCs.
> 
> Signed-off-by: Lukas Timmermann <uboot at timmermann.space>
> ---
> 
>  MAINTAINERS                                 |   5 +
>  drivers/pinctrl/exynos/Kconfig              |   8 ++
>  drivers/pinctrl/exynos/Makefile             |   1 +
>  drivers/pinctrl/exynos/pinctrl-exynos5250.c | 100 ++++++++++++++++++++
>  4 files changed, 114 insertions(+)
>  create mode 100644 drivers/pinctrl/exynos/pinctrl-exynos5250.c
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index cae855da60e..57c101d54b6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -606,6 +606,11 @@ F:	drivers/clk/exynos/clk-exynos850.c
>  F:	drivers/phy/phy-exynos-usbdrd.c
>  F:	drivers/pinctrl/exynos/pinctrl-exynos850.c
>  
> +ARM SAMSUNG EXYNOS5250 SOC
> +M:	Lukas Timmermann <uboot at timmermann.space>
> +S:	Maintained
> +F:	drivers/pinctrl/exynos/pinctrl-exynos5250.c
> +
>  ARM SAMSUNG SOC DRIVERS
>  M:	Sam Protsenko <semen.protsenko at linaro.org>
>  S:	Maintained
> diff --git a/drivers/pinctrl/exynos/Kconfig b/drivers/pinctrl/exynos/Kconfig
> index 1b7fb62bc4b..18503ce112e 100644
> --- a/drivers/pinctrl/exynos/Kconfig
> +++ b/drivers/pinctrl/exynos/Kconfig
> @@ -1,6 +1,14 @@
>  config PINCTRL_EXYNOS
>  	bool
>  
> +config PINCTRL_EXYNOS5250
> +	bool "Samsung Exynos5250 pinctrl driver"
> +	depends on ARCH_EXYNOS && PINCTRL_FULL
> +	select PINCTRL_EXYNOS
> +	help
> +	  Support pin multiplexing and pin configuration control on
> +	  Samsung's Exynos5250 SoC.
> +
>  config PINCTRL_EXYNOS7420
>  	bool "Samsung Exynos7420 pinctrl driver"
>  	depends on ARCH_EXYNOS && PINCTRL_FULL
> diff --git a/drivers/pinctrl/exynos/Makefile b/drivers/pinctrl/exynos/Makefile
> index 3abe1226eb7..7ef8d90cb59 100644
> --- a/drivers/pinctrl/exynos/Makefile
> +++ b/drivers/pinctrl/exynos/Makefile
> @@ -4,6 +4,7 @@
>  # Thomas Abraham <thomas.ab at samsung.com>
>  
>  obj-$(CONFIG_PINCTRL_EXYNOS)		+= pinctrl-exynos.o
> +obj-$(CONFIG_PINCTRL_EXYNOS5250)	+= pinctrl-exynos5250.o
>  obj-$(CONFIG_PINCTRL_EXYNOS7420)	+= pinctrl-exynos7420.o
>  obj-$(CONFIG_PINCTRL_EXYNOS78x0)	+= pinctrl-exynos78x0.o
>  obj-$(CONFIG_PINCTRL_EXYNOS850)		+= pinctrl-exynos850.o
> diff --git a/drivers/pinctrl/exynos/pinctrl-exynos5250.c b/drivers/pinctrl/exynos/pinctrl-exynos5250.c
> new file mode 100644
> index 00000000000..dfd86e7c0c0
> --- /dev/null
> +++ b/drivers/pinctrl/exynos/pinctrl-exynos5250.c
> @@ -0,0 +1,100 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2023 Linaro Ltd.
> + * Author: Sam Protsenko <semen.protsenko at linaro.org>
> + * Co-author: Lukas Timmermann <linux at timmermann.space>

I think "Co-author:" is generally not used, please consider settings
yourself as just "Author:"

> + *
> + * Exynos5250 pinctrl driver.
> + */
> +
> +#include <dm.h>
> +#include <dm/pinctrl.h>
> +#include "pinctrl-exynos.h"
> +
> +static const struct pinctrl_ops exynos5250_pinctrl_ops = {
> +	.set_state = exynos_pinctrl_set_state
> +};
> +
> +static const struct samsung_pin_bank_data exynos5250_pin_banks0[] = {
> +	EXYNOS_PIN_BANK(8, 0x000, "gpa0"),
> +	EXYNOS_PIN_BANK(6, 0x020, "gpa1"),
> +	EXYNOS_PIN_BANK(8, 0x040, "gpa2"),
> +	EXYNOS_PIN_BANK(5, 0x060, "gpb0"),
> +	EXYNOS_PIN_BANK(5, 0x080, "gpb1"),
> +	EXYNOS_PIN_BANK(4, 0x0A0, "gpb2"),
> +	EXYNOS_PIN_BANK(4, 0x0C0, "gpb3"),
> +	EXYNOS_PIN_BANK(7, 0x0E0, "gpc0"),
> +	EXYNOS_PIN_BANK(4, 0x100, "gpc1"),
> +	EXYNOS_PIN_BANK(7, 0x120, "gpc2"),
> +	EXYNOS_PIN_BANK(7, 0x140, "gpc3"),
> +	EXYNOS_PIN_BANK(4, 0x160, "gpd0"),
> +	EXYNOS_PIN_BANK(8, 0x180, "gpd1"),
> +	EXYNOS_PIN_BANK(7, 0x2E0, "gpc4"),
> +	EXYNOS_PIN_BANK(6, 0x1A0, "gpy0"),
> +	EXYNOS_PIN_BANK(4, 0x1C0, "gpy1"),
> +	EXYNOS_PIN_BANK(6, 0x1E0, "gpy2"),
> +	EXYNOS_PIN_BANK(8, 0x200, "gpy3"),
> +	EXYNOS_PIN_BANK(8, 0x220, "gpy4"),
> +	EXYNOS_PIN_BANK(8, 0x240, "gpy5"),
> +	EXYNOS_PIN_BANK(8, 0x260, "gpy6"),
> +	EXYNOS_PIN_BANK(8, 0xC00, "gpx0"),
> +	EXYNOS_PIN_BANK(8, 0xC20, "gpx1"),
> +	EXYNOS_PIN_BANK(8, 0xC40, "gpx2"),
> +	EXYNOS_PIN_BANK(8, 0xC60, "gpx3"),
> +};
> +
> +static const struct samsung_pin_bank_data exynos5250_pin_banks1[] = {
> +	EXYNOS_PIN_BANK(8, 0x000, "gpe0"),
> +	EXYNOS_PIN_BANK(2, 0x020, "gpe1"),
> +	EXYNOS_PIN_BANK(4, 0x040, "gpf0"),
> +	EXYNOS_PIN_BANK(4, 0x060, "gpf1"),
> +	EXYNOS_PIN_BANK(8, 0x080, "gpg0"),
> +	EXYNOS_PIN_BANK(8, 0x0A0, "gpg1"),
> +	EXYNOS_PIN_BANK(2, 0x0C0, "gpg2"),
> +	EXYNOS_PIN_BANK(4, 0x0E0, "gph0"),
> +	EXYNOS_PIN_BANK(8, 0x100, "gph1"),
> +};
> +
> +static const struct samsung_pin_bank_data exynos5250_pin_banks2[] = {
> +	EXYNOS_PIN_BANK(8, 0x000, "gpv0"),
> +	EXYNOS_PIN_BANK(8, 0x020, "gpv1"),
> +	EXYNOS_PIN_BANK(8, 0x060, "gpv2"),
> +	EXYNOS_PIN_BANK(8, 0x080, "gpv3"),
> +	EXYNOS_PIN_BANK(2, 0x0C0, "gpv4"),

Lower-case letters in the constants please, in all the bank structs.

Otherwise looks good to me, thanks!

Best regards,
Henrik Grimler

> +};
> +
> +static const struct samsung_pin_bank_data exynos5250_pin_banks3[] = {
> +	EXYNOS_PIN_BANK(7, 0x000, "gpz"),
> +};
> +
> +static const struct samsung_pin_ctrl exynos5250_pin_ctrl[] = {
> +	{
> +		.pin_banks	= exynos5250_pin_banks0,
> +		.nr_banks	= ARRAY_SIZE(exynos5250_pin_banks0),
> +	}, {
> +		.pin_banks	= exynos5250_pin_banks1,
> +		.nr_banks	= ARRAY_SIZE(exynos5250_pin_banks1),
> +	}, {
> +		.pin_banks	= exynos5250_pin_banks2,
> +		.nr_banks	= ARRAY_SIZE(exynos5250_pin_banks2),
> +	}, {
> +		.pin_banks	= exynos5250_pin_banks3,
> +		.nr_banks	= ARRAY_SIZE(exynos5250_pin_banks3),
> +	},
> +	{/* list terminator */}
> +};
> +
> +static const struct udevice_id exynos5250_pinctrl_ids[] = {
> +	{ .compatible = "samsung,exynos5250-pinctrl",
> +		.data = (ulong)exynos5250_pin_ctrl },
> +	{ }
> +};
> +
> +U_BOOT_DRIVER(pinctrl_exynos5250) = {
> +	.name		= "pinctrl_exynos5250",
> +	.id			= UCLASS_PINCTRL,
> +	.of_match	= exynos5250_pinctrl_ids,
> +	.priv_auto	= sizeof(struct exynos_pinctrl_priv),
> +	.ops		= &exynos5250_pinctrl_ops,
> +	.probe		= exynos_pinctrl_probe,
> +};
> -- 
> 2.51.0
>