[PATCH 4/6] i2c: npcm: Fix error detection
Andrew Goodbody
andrew.goodbody at linaro.org
Tue Oct 21 18:08:28 CEST 2025
Testing an unisgned member of a struct to be <= 0 will only detect the
case when it is 0. So correct this error test to a working version that
will behave as expected.
Signed-off-by: Andrew Goodbody <andrew.goodbody at linaro.org>
---
drivers/i2c/npcm_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/npcm_i2c.c b/drivers/i2c/npcm_i2c.c
index bff0d04f1a5ae2c261657a5776b38e4ab6ad4d28..d57237a6df167d579ab4b8d45f3989a8cac0fc68 100644
--- a/drivers/i2c/npcm_i2c.c
+++ b/drivers/i2c/npcm_i2c.c
@@ -573,7 +573,7 @@ static int npcm_i2c_probe(struct udevice *dev)
return ret;
}
bus->apb_clk = clk_get_rate(&clk);
- if (bus->apb_clk <= 0) {
+ if (!bus->apb_clk || IS_ERR_VALUE(bus->apb_clk)) {
printf("%s: fail to get rate\n", __func__);
return -EINVAL;
}
--
2.47.3
More information about the U-Boot
mailing list