[PATCH] imx: Revert "imx: mx6ull: fix REFTOP_VBGADJ setting" and fix comments

[Tom Rini]

On Mon, Oct 27, 2025 at 08:56:38AM -0300, Fabio Estevam wrote:

> From: Ye Li <ye.li at nxp.com>
> 
> The change in commit c1af358cf51a ("imx: mx6ull: fix REFTOP_VBGADJ
> setting") is not correct. According to latest i.MX6ULL fuse table,
> the REFTOP_TRIM[2:0] fuse is defined as below. So the previous codes
> are correct, only need to fix the comments.
> 
> Set the REFTOP_VBGADJ field in PMU_MISC0 register based on the
> REFTOP_TRIM fuse:
> '000" - set REFTOP_VBGADJ[2:0] to 3'b000
> '001" - set REFTOP_VBGADJ[2:0] to 3'b001
> '010" - set REFTOP_VBGADJ[2:0] to 3'b010
> '011" - set REFTOP_VBGADJ[2:0] to 3'b011
> '100" - set REFTOP_VBGADJ[2:0] to 3'b100
> '101" - set REFTOP_VBGADJ[2:0] to 3'b101
> '110" - set REFTOP_VBGADJ[2:0] to 3'b110
> '111" - set REFTOP_VBGADJ[2:0] to 3'b111
> 
> Sven Schwermer reported:
> 
> "These are the symptoms: Very few of the thousands of devices that we
> manufacture (< 1%) fail to decompress a large XZ archive once in Linux
> userspace. We have not found any form of memory testing or other load
> that reproduces this issue. Reverting the offending patch fixes this
> behavior on the affected devices."
> 
> Revert the offending commit to fix the regression.
> 
> Reported-by: Sven Schwermer <u-boot at schwermer.no>
> Signed-off-by: Ye Li <ye.li at nxp.com>
> [fabio: Fixed checkpatch warning and added Sven's report]
> Signed-off-by: Fabio Estevam <festevam at gmail.com>

And after reading the discussion on the older patch, this does seem to
be the right way forward.

Reviewed-by: Tom Rini <trini at konsulko.com>
Link: https://lore.kernel.org/u-boot/1646721735-125430-1-git-send-email-ye.li@nxp.com/

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20251027/f4f81fa4/attachment.sig>