[PATCH v3 1/3] event: Check return value from event_notify_null()
Michal Simek
michal.simek at amd.com
Wed Apr 1 08:03:44 CEST 2026
event_notify_null() returns int but its return value is not
checked in run_main_loop() and in fwu_mdata tests.
Add proper error checking to all unchecked call sites.
Signed-off-by: Michal Simek <michal.simek at amd.com>
Reviewed-by: Simon Glass <sjg at chromium.org>
---
(no changes since v2)
Changes in v2:
- new patch in series
common/board_r.c | 6 +++++-
test/dm/fwu_mdata.c | 4 ++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/common/board_r.c b/common/board_r.c
index 8cf0e14679c0..5d37345ca09d 100644
--- a/common/board_r.c
+++ b/common/board_r.c
@@ -569,11 +569,15 @@ static int dm_announce(void)
static int run_main_loop(void)
{
+ int ret;
+
#ifdef CONFIG_SANDBOX
sandbox_main_loop_init();
#endif
- event_notify_null(EVT_MAIN_LOOP);
+ ret = event_notify_null(EVT_MAIN_LOOP);
+ if (ret)
+ return ret;
/* main_loop() can return to retry autoboot, if so just run it again */
for (;;)
diff --git a/test/dm/fwu_mdata.c b/test/dm/fwu_mdata.c
index b7680632f95f..643b647af0a9 100644
--- a/test/dm/fwu_mdata.c
+++ b/test/dm/fwu_mdata.c
@@ -100,7 +100,7 @@ static int dm_test_fwu_mdata_read(struct unit_test_state *uts)
* Trigger lib/fwu_updates/fwu.c fwu_boottime_checks()
* to populate g_dev global pointer in that library.
*/
- event_notify_null(EVT_MAIN_LOOP);
+ ut_assertok(event_notify_null(EVT_MAIN_LOOP));
ut_assertok(uclass_first_device_err(UCLASS_FWU_MDATA, &dev));
ut_assertok(fwu_init());
@@ -127,7 +127,7 @@ static int dm_test_fwu_mdata_write(struct unit_test_state *uts)
* Trigger lib/fwu_updates/fwu.c fwu_boottime_checks()
* to populate g_dev global pointer in that library.
*/
- event_notify_null(EVT_MAIN_LOOP);
+ ut_assertok(event_notify_null(EVT_MAIN_LOOP));
ut_assertok(uclass_first_device_err(UCLASS_FWU_MDATA, &dev));
--
2.43.0
More information about the U-Boot
mailing list