[0/4] fit: dm-verity support
Simon Glass
sjg at chromium.org
Thu Apr 2 18:35:17 CEST 2026
Hi Daniel,
On 2026-04-02T03:08:27, Daniel Golle <daniel at makrotopia.org> wrote:
> Only the three user-provided properties (algo, data-block-size,
> hash-block-size) are included; mkimage computes and fills in digest,
> salt, num-data-blocks, and hash-start-block automatically
The .its example contradicts this statement -- it includes all six
dm-verity properties, not just the three user-provided ones. Please
can you either trim the example to show only the minimal user input
(which would be more useful as a template) or just update the text
here.
> 9 files changed, 1215 insertions(+)
The series adds a sizeable new feature to both mkimage and the boot
path so it should have tests.
See test/py/tests/test_fit*.py - for example test_fit_hashes.py
exercises hash computation.
Since you are adding Merkle-tree generation and cmdline construction,
a pytest that builds an ITS with a dm-verity node, runs mkimage, and
checks the resulting properties would give reasonable coverage.
A runtime test is harder without a real fitblk driver, but even a unit
test verifying fit_verity_build_cmdline() output against known
metadata would help.
Regards,
Simon
More information about the U-Boot
mailing list