[PATCH] xiaomi pad 5 support

[Yao Zi]

On Fri, Apr 03, 2026 at 07:01:26PM +0300, Lobanokivan11 wrote:
> ---
>  board/qualcomm/xiaomi-nabu.env                |   11 +
>  configs/xiaomi-nabu_defconfig                 |    6 +
>  dts/upstream/src/arm64/qcom/pm8150.dtsi       |   10 +-
>  dts/upstream/src/arm64/qcom/pm8150b.dtsi      |    8 +

Devicetree (and bindings) in dts/ are pulled from devicetree
upstream[1] (i.e., Linux kernel), and you shouldn't directly modify
files in it. If you need a commit in dts upstream that hasn't
synchronized into U-Boot yet, tools/update-subtree.sh might be used for
cherry-picking one commit once it has landed in Linux master.

However, I don't see such changes to pm8150(b).dtsi in Linux 7.0-rc6, so
you might want to push the changes to Linux upstream first.

>  .../src/arm64/qcom/sm8150-oneplus-common.dtsi |  545 ++++++++
>  .../arm64/qcom/sm8150-oneplus-guacamole.dts   |   70 +
>  .../src/arm64/qcom/sm8150-oneplus-hotdogb.dts |   65 +
>  .../src/arm64/qcom/sm8150-wcd9340.dtsi        |   86 ++
>  .../src/arm64/qcom/sm8150-xiaomi-cepheus.dts  |  575 ++++++++
>  .../src/arm64/qcom/sm8150-xiaomi-nabu.dts     | 1175 +++++++++++++++++
>  dts/upstream/src/arm64/qcom/sm8150.dtsi       |  102 ++
>  11 files changed, 2652 insertions(+), 1 deletion(-)
>  create mode 100644 board/qualcomm/xiaomi-nabu.env
>  create mode 100644 configs/xiaomi-nabu_defconfig
>  create mode 100644 dts/upstream/src/arm64/qcom/sm8150-oneplus-common.dtsi
>  create mode 100644 dts/upstream/src/arm64/qcom/sm8150-oneplus-guacamole.dts
>  create mode 100644 dts/upstream/src/arm64/qcom/sm8150-oneplus-hotdogb.dts
>  create mode 100644 dts/upstream/src/arm64/qcom/sm8150-wcd9340.dtsi
>  create mode 100644 dts/upstream/src/arm64/qcom/sm8150-xiaomi-cepheus.dts
>  create mode 100644 dts/upstream/src/arm64/qcom/sm8150-xiaomi-nabu.dts

What's the relationship between Xiaomi Pad 5 and
"oneplus-guacamole/hotdogb"? The latter doesn't seem to match subject of
the patch, which is "xiaomi pad 5 support". You probably want to have a
separate commit for the non-xiaomi stuff.

And, for the same reason as above, you should neither create files in
dts/ manually. I don't think these devicetrees have been in upstream,
either. An alternative is to put them in arch/arm/dts instead, but it'll
still be nice to have them upstreamed first.

...

> diff --git a/dts/upstream/src/arm64/qcom/pm8150.dtsi b/dts/upstream/src/arm64/qcom/pm8150.dtsi
> index d2568686a09..c3411b308e3 100644
> --- a/dts/upstream/src/arm64/qcom/pm8150.dtsi
> +++ b/dts/upstream/src/arm64/qcom/pm8150.dtsi
> @@ -116,13 +116,21 @@
>  			status = "disabled";
>  		};
>  
> -		rtc at 6000 {
> +		pm8150_rtc: rtc at 6000 {
>  			compatible = "qcom,pm8941-rtc";
>  			reg = <0x6000>, <0x6100>;
>  			reg-names = "rtc", "alarm";
>  			interrupts = <0x0 0x61 0x1 IRQ_TYPE_NONE>;
>  		};

It's possible to refer a devicetree node by using its full path, which
may help if you decide not to upstream changes in pm8150.dtsi first.

> +		pm8150_sdam_2: sdam at b100 {
> +			compatible = "qcom,spmi-sdam";
> +			reg = <0xb100>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			status = "disabled";
> +		};
> +
>  		pm8150_gpios: gpio at c000 {
>  			compatible = "qcom,pm8150-gpio", "qcom,spmi-gpio";
>  			reg = <0xc000>;

Regards,
Yao Zi

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git