[PATCH v5 3/6] misc: fw_loader: implement generic get_fw_loader_from_node()

Simon Glass sjg at chromium.org
Mon Apr 6 19:10:14 CEST 2026


Hi Christian,

On 2026-04-03T13:51:57, Christian Marangi <ansuelsmth at gmail.com> wrote:
> misc: fw_loader: implement generic get_fw_loader_from_node()
>
> Implement a generic function to get a FW loader dev from a node.
>
> There is currently only get_fs_loader() but that is limited to chosen
> node and is limited only to FS loader.
>
> Introduce get_fw_loader_from_node() that will parse the
> "firmware-loader" from a specified node and will search and probe a
> matching FW loader device, if found.
>
> Signed-off-by: Christian Marangi <ansuelsmth at gmail.com>

> diff --git a/include/fw_loader.h b/include/fw_loader.h
> @@ -6,8 +6,23 @@
> + * Loop over all the supported FW loader and find a matching
> + * one.

Is there a compatible string for this node? Is it in the DT schema?

The comment says it loops over all supported FW loaders but the
implementation does a direct lookup by ofnode with
device_find_global_by_ofnode(). Please can you update the comment to
match.

Regards,
Simon


More information about the U-Boot mailing list