[PATCH 5/5] dts: add empty .dtsi for shift-axolotl
Michael Srba
Michael.Srba at seznam.cz
Tue Apr 7 00:54:21 CEST 2026
Hi,
On 4/6/26 17:53, Simon Glass wrote:
> Hi Michael,
>
> On 2026-04-03T23:18:18, Michael Srba <michael.srba at seznam.cz> wrote:
>> dts: add empty .dtsi for shift-axolotl
>>
>> This is necessary to select shift-axolotl as a target, in practice
>> the upstream dts will be used
>>
>> Signed-off-by: Michael Srba <Michael.Srba at seznam.cz>
>> diff --git a/arch/arm/dts/sdm845-shift-axolotl-u-boot.dtsi b/arch/arm/dts/sdm845-shift-axolotl-u-boot.dtsi
>> +// SPDX-License-Identifier: GPL-2.0
>> +
>> +/* When there is no previous bootloader, the memory node won't get filled in.
>> + */
> The build system uses the first matching -u-boot.dtsi file. Since this
> board-specific file exists, it takes priority over sdm845-u-boot.dtsi,
> which adds bootph-all properties to gcc, usb_1_hsphy, usb_1_dwc3, and
> rpmhcc needed for USB DFU in SPL.
>
> Please can you add:
>
> #include "sdm845-u-boot.dtsi"
>
> This is the standard pattern - e.g. meson-gxbb-p200-u-boot.dtsi which
> includes meson-gxbb-u-boot.dtsi.
I just realized my (compile) testing was flawed and used existing artifacts,
fixing that and doing a proper clean build alerted me to the fact that
messing with CONFIG_SYS_SOC is a terrible idea that leads to pain and
suffering, so I will absolutely be simply using an include instead in v2.
> The commit message says the file is 'empty' but it contains a comment
> about memory. If that comment is relevant, perhaps clarify what it
> means for this board. Otherwise I suggest removing it until there is
> actual content.
That's definitely a copy paste error, I was copying the SPDX header since a fully
empty file was still triggering license error and must've slipped. will fix.
> Regards,
> Simon
More information about the U-Boot
mailing list