[PATCH 2/5] of_live: support in SPL
Michael Srba
Michael.Srba at seznam.cz
Tue Apr 7 00:57:33 CEST 2026
On 4/6/26 17:51, Simon Glass wrote:
> Hi Michael,
>
> On 2026-04-03T23:18:18, Michael Srba <michael.srba at seznam.cz> wrote:
>> of_live: support in SPL
>>
>> Add CONFIG_SPL_OF_LIVE and if set, initialize of_live in spl.c
>>
>> Signed-off-by: Michael Srba <Michael.Srba at seznam.cz>
>> diff --git a/dts/Kconfig b/dts/Kconfig
>> @@ -86,6 +86,11 @@ config OF_LIVE
>> +config SPL_OF_LIVE
>> + bool "Enable use of a live tree in SPL"
>> + depends on SPL_DM && SPL_OF_CONTROL
>> +
>> +
> Please can you add help text here? The main OF_LIVE option has a
> helpful explanation. Also there should only be one blank line after
> the entry.
>
It seems some SPL options just refer to the full option and some copy
the explanation, my worry with the latter is that it will most definitely not
stay in sync, but I'm happy to go with either approach.
>> diff --git a/common/spl/spl.c b/common/spl/spl.c
>> @@ -510,6 +511,15 @@ static int spl_common_init(bool setup_malloc)
>> + if (CONFIG_IS_ENABLED(OF_LIVE)) {
>> + ret = of_live_build(gd->fdt_blob,
>> + (struct device_node **)gd_of_root_ptr());
>> + if (ret) {
>> + debug("of_live_build() returned error %d\n", ret);
>> + return ret;
>> + }
>> + }
> The U-Boot proper code in initr_of_live() wraps of_live_build() with
> bootstage_start()/bootstage_accum() using BOOTSTAGE_ID_ACCUM_OF_LIVE.
> Please can you do the same here for consistency and SPL boot-time
> tracking.
I wasn't sure if SPL supported that, probably should've tried harder to check.
will fix.
> Regards,
> Simon
More information about the U-Boot
mailing list