[PATCH v2 2/4] pinctrl: mediatek: mt8189: fix pinconf bias

[Macpaul Lin (林智斌)]

On Mon, 2026-03-30 at 11:00 -0500, David Lechner wrote:
> Fix setting pinconf bias for MT8189.
> 
> Using mtk_pinconf_bias_set_v1() was wrong because MT8189 does not
> have
> PULLEN/PULLSEL registers. It has PU and PD registers for most pins.
> MSDC pins need special handling since they have PUPD/R1/R0 registers.
> I2C pins need special handling since they have PU/PD/RSEL registers.
> New groups are added for MSDC and I2C pins and the bias_set callback
> is now set appropriately for all groups.
> 
> A new table is needed for the RSEL registers since those were
> missing.
> 
> Some new macros are introduced to avoid repeating the same info many
> times in MTK_TYPED_PIN(). This also fixes the semantically incorrect
> use of DRV_GRPX for the IO_TYPE_GRPX field.
> 
> Signed-off-by: David Lechner <dlechner at baylibre.com>
> ---
>  drivers/pinctrl/mediatek/pinctrl-mt8189.c | 413 +++++++++++++++++---
> ----------
>  1 file changed, 229 insertions(+), 184 deletions(-)
> 

[Snip...]

Reviewed-by: Macpaul Lin <macpaul.lin at mediatek.com>

Thanks!
Macpaul Lin