[PATCH v2 4/5] virtio: mmio: Allow instantiation via platform data
Daniel Palmer
daniel at thingy.jp
Wed Apr 8 11:39:37 CEST 2026
Hi Kuan-Wei,
On Wed, 8 Apr 2026 at 10:47, Kuan-Wei Chiu <visitorckw at gmail.com> wrote:
> >
> > U_BOOT_DRIVER(virtio_mmio) = {
> > - .name = "virtio-mmio",
> > - .id = UCLASS_VIRTIO,
> > - .of_match = virtio_mmio_ids,
> > - .ops = &virtio_mmio_ops,
> > - .probe = virtio_mmio_probe,
> > + .name = "virtio-mmio",
> > + .id = UCLASS_VIRTIO,
> > + .of_match = virtio_mmio_ids,
> > + .ops = &virtio_mmio_ops,
> > + .probe = virtio_mmio_probe,
>
> Just realized this didn't send earlier.
>
> The patch looks good overall.
> However, I noticed some changes involving tabs vs. spaces.
> Do we have a specific style rule requiring spaces instead of tabs here?
>From memory, when I aligned it using tabs it didn't look very nice so
aligning with spaces worked out better.
Cheers,
Daniel
More information about the U-Boot
mailing list