[PATCH 8/8] spi: mtk_snor: Remove status register write procedure in probe()

David Lechner dlechner at baylibre.com
Wed Apr 8 21:04:43 CEST 2026


On 4/6/26 3:13 PM, David Lechner wrote:
> From: Meiker Gao <ot_meiker.gao at mediatek.com>
> 
> Remove status register write procedure in probe(). This is handled in
> spi-nor-core by the SPI_NOR_HAS_LOCK flag.
> 
> Signed-off-by: Meiker Gao <ot_meiker.gao at mediatek.com>
> Signed-off-by: David Lechner <dlechner at baylibre.com>
> ---
>  drivers/spi/mtk_snor.c | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/drivers/spi/mtk_snor.c b/drivers/spi/mtk_snor.c
> index 21ac115e3c3..3b9eac383ab 100644
> --- a/drivers/spi/mtk_snor.c
> +++ b/drivers/spi/mtk_snor.c
> @@ -567,19 +567,6 @@ static int mtk_snor_probe(struct udevice *bus)
>  	mtk_snor_rmw(priv, MTK_NOR_REG_CFG3,
>  		     MTK_NOR_DISABLE_WREN | MTK_NOR_DISABLE_SR_POLL, 0);
>  
> -	/*
> -	 * Unlock all blocks using write status command.
> -	 * SPI-MEM hasn't implemented unlock procedure on MXIC devices.
> -	 * We may remove this later.
> -	 */
> -	writel(2 * BITS_PER_BYTE, priv->base + MTK_NOR_REG_PRG_CNT);
> -	writel(MTK_NOR_UNLOCK_ALL, priv->base + MTK_NOR_REG_PRGDATA(5));
> -	writel(MTK_NOR_IRQ_WRSR, priv->base + MTK_NOR_REG_IRQ_EN);
> -	writel(MTK_NOR_CMD_WRSR, priv->base + MTK_NOR_REG_CMD);
> -	ret = readl_poll_timeout(priv->base + MTK_NOR_REG_IRQ_STAT, reg,

This was the only user of reg, so we need to remove that too.

../drivers/spi/mtk_snor.c: In function ‘mtk_snor_probe’:
../drivers/spi/mtk_snor.c:530:13: warning: unused variable ‘reg’ [-Wunused-variable]
  530 |         u32 reg;
      |             ^~~

> -				 !(reg & MTK_NOR_IRQ_WRSR),
> -				 ((3 * BITS_PER_BYTE) + 1) * 200);
> -
>  	return 0;
>  }
>  
> 



More information about the U-Boot mailing list