[PATCH v2 6/7] fwu: add helper to get image GUID by type and bank index

[Simon Glass]

Hi Dario,

On 2026-04-04T15:23:27, Dario Binacchi
<dario.binacchi at amarulasolutions.com> wrote:
> fwu: add helper to get image GUID by type and bank index
>
> Introduce fwu_mdata_get_image_guid() to retrieve a specific image GUID
> from the FWU metadata based on the bank index and image type GUID.
>
> This allows identifying the correct partition in multi-bank (A/B)
> scenarios, ensuring the correct image is targeted depending on the
> current bank.
>
> Signed-off-by: Dario Binacchi <dario.binacchi at amarulasolutions.com>
>
> include/fwu.h         |  3 +++
>  lib/fwu_updates/fwu.c | 33 +++++++++++++++++++++++++++++++++
>  test/hooks/bin/u      |  1 +
>  3 files changed, 37 insertions(+)

> diff --git a/include/fwu.h b/include/fwu.h
> @@ -396,6 +396,9 @@ void fwu_populate_mdata_image_info(struct fwu_data *data);
> +int fwu_mdata_get_image_guid(efi_guid_t *image_guid,
> +                          const efi_guid_t *image_type_guid, u32 bank_index);

The cover letter mentions 'Add kerneldoc comment for
fwu_mdata_get_image_guid()' but the header declaration has no
kerneldoc. Please can you add it before the declaration in fwu.h to
match other functions in this file? The comment in fwu.c is good, but
the U-Boot convention is to document public APIs in the header.

Regards,
Simon