[PATCH v2 02/10] of_live: support in SPL

[Simon Glass]

Hi Michael,

On 2026-04-11T00:00:12, Michael Srba <michael.srba at seznam.cz> wrote:
> of_live: support in SPL
>
> Add CONFIG_SPL_OF_LIVE and if set, initialize of_live in spl.c
>
> Signed-off-by: Michael Srba <Michael.Srba at seznam.cz>
>
> common/spl/spl.c | 11 +++++++++++
>  dts/Kconfig      |  6 ++++++
>  lib/Makefile     |  2 +-
>  3 files changed, 18 insertions(+), 1 deletion(-)

> diff --git a/common/spl/spl.c b/common/spl/spl.c
> @@ -510,6 +511,16 @@ static int spl_common_init(bool setup_malloc)
> +     if (CONFIG_IS_ENABLED(OF_LIVE)) {
> +             int ret;

This shadows ret already declared at function scope. Please drop the
inner declaration.

> diff --git a/dts/Kconfig b/dts/Kconfig
> @@ -86,6 +86,12 @@ config OF_LIVE
> +config SPL_OF_LIVE
> +     bool "Enable use of a live tree in SPL"
> +     depends on SPL_DM && SPL_OF_CONTROL
> +     help
> +       This option enables a live tree in SPL.

The help text is sparse compared to OF_LIVE. Please can you explain
why one might enable this in SPL.

Reviewed-by: Simon Glass <sjg at chromium.org>

Regards,
Simon