[PATCH v1] arm: socfpga: soc64: separate reset manager into common and platform-family parts

Lok, Chen Huei chen.huei.lok at altera.com
Wed Apr 15 02:59:06 CEST 2026


Hi Tien Fong,

Thanks for the review.
I agree with both points and will fold them into v2:
>> The SoCFPGA SoC64 reset manager code is currently built as
>> reset_manager_s10.o even though it is shared across multiple SoC64
>> families.
>> Split the implementation into:
>> - reset_manager_soc64.o for common SoC64 logic
>> - reset_manager_soc64_platform_families.o for platform-family-specific
> Consider a shorter/more conventional name than reset_manager_soc64_platform_families.c
> e.g. reset_manager_soc64_families.c
Rename reset_manager_soc64_platform_families.c to 
reset_manager_soc64_families.c (and update the Makefile accordingly).
>> +#include <errno.h>
>> +#include <exports.h>
>> +#include <hang.h>
>> +#include <asm/global_data.h>
>> +#include <asm/io.h>
>> +#include <asm/secure.h>
>> +#include <asm/arch/reset_manager.h>
>> +#include <asm/arch/smc_api.h>
> Includes SMC + secure headers, but the functions shown don’t use them.
> Prefer minimal includes. This improves compile times and reduces coupling

Trim reset_manager_soc64.c & reset_manager_soc64_families.c to only the 
includes that are actually used.

Best regards,
Lok



More information about the U-Boot mailing list