[PATCH 1/2] clk: mediatek: remove redundant forward declarations

sam.shih sam.shih at mediatek.com
Wed Apr 15 09:41:12 CEST 2026


Hi David,
 
Thanks for the review and the suggestions.
 
We will rework this series as three patches with a cover letter.
 
1/3: Remove the redundant forward declarations and drop the Fixes: tag
from this change.
 
2/3: Adjust the code formatting and declarations so that the functional
fix in patch 3/3 applies cleanly and passes checkpatch.pl.
 
3/3: Add the actual functional fix for the parent rate lookup.


On Fri, 2026-04-10 at 11:07 -0500, David Lechner wrote:
> On 4/9/26 9:12 PM, Weijie Gao wrote:
> > From: Sam Shih <sam.shih at mediatek.com>
> > 
> > The clk_ops structures (mtk_clk_apmixedsys_ops,
> > mtk_clk_topckgen_ops,
> > mtk_clk_infrasys_ops) are already declared with extern in clk-
> > mtk.h,
> > which is included by this file. The forward declarations in clk-
> > mtk.c
> > are therefore redundant and can be removed.
> > 
> 
> > Fixes: 00d0ff7f81bf ("clk: mediatek: refactor parent rate lookup
> > functions")
> 
> Since this is just redundant and didn't actually break anything, the
> Fixes: tag is not appropriate. We can remove it.
> 
> 
> It is also helpful to include a cover letter when sending multiple
> patches.


Best regards,
Sam


More information about the U-Boot mailing list