[PATCH v3 03/10] pinctrl: qcom: Add ipq5210 pinctrl driver

[Simon Glass]

Hi Varadarajan,

On 2026-04-16T05:39:18, Varadarajan Narayanan
<varadarajan.narayanan at oss.qualcomm.com> wrote:
> pinctrl: qcom: Add ipq5210 pinctrl driver
>
> Add pinctrl driver for the TLMM block found in the ipq5210 SoC.
>
> Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan at oss.qualcomm.com>
>
> drivers/pinctrl/qcom/Kconfig           |   8 +
>  drivers/pinctrl/qcom/Makefile          |   1 +
>  drivers/pinctrl/qcom/pinctrl-ipq5210.c | 349 +++++++++++++++++++++++++++++++++
>  3 files changed, 358 insertions(+)

> +static const struct msm_pinctrl_data ipq5210_data = {
> +     .pin_data = {
> +             .pin_count = 53,
> +             .special_pins_start = 53, /* There are no special pins */

>From my reading, the PINGROUP definitions run from 0 to 53, which is
54 pins, so shouldn't these two be 54 ?

> +     pr_err("Can't find requested function for pin %u pin\n", pin);

The word 'pin' appears twice

Regards,
Simon