[PATCH v3 07/10] mach-snapdragon: spl: Update SMEM with boot details

[Simon Glass]

Hi Varadarajan,

On 2026-04-16T05:39:18, Varadarajan Narayanan
<varadarajan.narayanan at oss.qualcomm.com> wrote:
> mach-snapdragon: spl: Update SMEM with boot details
>
> Update SMEM with the storage medium from which the system booted.
>
> Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan at oss.qualcomm.com>
>
> arch/arm/mach-snapdragon/spl.c | 65 ++++++++++++++++++++++++++++++++++++++++++
>  include/smem.h                 |  3 ++
>  2 files changed, 68 insertions(+)

> +     if (IS_ENABLED(CONFIG_SPL_MMC))
> +             *fltype = SMEM_BOOT_MMC_FLASH;
> +     return 0;
> +}

If CONFIG_SPL_MMC is not enabled, fltype is left uninitialised. The
function should either set a default value or return an error when no
boot medium matches.

> +}
> +#endif /* IS_ENABLED(CONFIG_SPL_SMEM) */
> +/**

Missing blank line between the #endif and the next function comment.

> +void spl_board_prepare_for_boot(void)
> +{
> +     int ret;
> +
> +     /*
> +      * Populate SMEM in coldboot (Dload bit not set)
> +      */
> +     if (!QCOM_SPL_IS_DLOAD_BIT_SET) {
> +             printf("Populating SMEM\n");

This printf() is user-visible during every coldboot - try log_debug() etc.

Regards,
Simon