[PATCH v3 08/10] mach-snapdragon: Add commands to create wrapper ELF

[Simon Glass]

Hi Varadarajan,

On 2026-04-16T05:39:18, Varadarajan Narayanan
<varadarajan.narayanan at oss.qualcomm.com> wrote:
> mach-snapdragon: Add commands to create wrapper ELF
>
> The IPQ5210 boot ROM expects the SPL binary image to be embedded within
> an ELF along with additional binaries. Hence add the relevant commands
> and linker script needed to convert u-boot-spl.bin to the expected
> format.
>
> Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan at oss.qualcomm.com>
>
> arch/arm/mach-snapdragon/Kconfig                  |  7 +++++++
>  arch/arm/mach-snapdragon/ipq5210-spl-wrap-elf.lds | 18 +++++++++++++++++
>  scripts/Makefile.xpl                              | 24 +++++++++++++++++++++++
>  3 files changed, 49 insertions(+)

> +ifeq ($(CONFIG_ARCH_SNAPDRAGON),y)
> +INPUTS-$(CONFIG_SPL_WRAPPER_ELF) += spl/u-boot-spl.wrap-elf
> +endif

Please can you use $(obj)/$(SPL_BIN).wrap-elf here to follow the
convention used elsewhere in this file. The hardcoded path would break
out-of-tree builds.

> +/*
> + * SPDX-License-Identifier: GPL-2.0

U-Boot convention for new files is GPL-2.0+ - is that OK, or do you need 2.0 ?

Regards,
Simon