[RESEND v4 02/14] mach-sc5xx: Remove update commands from default environment

Simon Glass sjg at chromium.org
Mon Apr 20 04:50:29 CEST 2026


Hi Caleb,

On 2026-04-16T15:19:35, Caleb Ethridge <jcethrid at gmail.com> wrote:
> mach-sc5xx: Remove update commands from default environment
>
> Remove the update_spi family of commands from the U-boot
> environment. These commands are not standard in U-boot,
> and boot media programming has moved to Linux, so the
> commands can be safely removed.
>
> Signed-off-by: Caleb Ethridge <caleb.ethridge at analog.com>
>
> board/adi/sc573-ezkit/sc573-ezkit.env           |  2 -
>  board/adi/sc584-ezkit/sc584-ezkit.env           |  2 -
>  board/adi/sc589-ezkit/sc589-ezkit.env           |  2 -
>  board/adi/sc589-mini/sc589-mini.env             |  2 -
>  board/adi/sc594-som-ezkit/sc594-som-ezkit.env   |  2 -
>  board/adi/sc594-som-ezlite/sc594-som-ezlite.env |  2 -
>  board/adi/sc598-som-ezkit/sc598-som-ezkit.env   |  2 -
>  board/adi/sc598-som-ezlite/sc598-som-ezlite.env |  2 -
>  configs/sc573-ezkit_defconfig                   |  2 -
>  configs/sc584-ezkit_defconfig                   |  2 -
>  configs/sc589-ezkit_defconfig                   |  2 -
>  configs/sc589-mini_defconfig                    |  2 -
>  include/env/adi/adi_boot.env                    | 53 -------------------------
>  13 files changed, 77 deletions(-)

> diff --git a/include/env/adi/adi_boot.env b/include/env/adi/adi_boot.env
> @@ -1,9 +1,7 @@
>  /*
>   * A target board needs to set these variables for the commands below to work:
>   *
> - * - adi_stage2_offset, the location of stage2-boot.ldr on the SPI flash
>   * - adi_image_offset, location of the fitImage on the SPI flash
> - * - adi_rfs_offset, location of the RFS on the SPI flash
>   * - loadaddr, where you want to load things
>   * - jffs2file, name of the jffs2 file for update, ex adsp-sc5xx-tiny-adsp-sc573.jffs2

The comment mentions jffs2file as still required. Patch 10 removes
jffs2file from all boards. Please can you also update this comment in
that patch.

BTW, CONFIG_SC5XX_UBOOT_OFFSET, CONFIG_SC5XX_FITIMAGE_OFFSET, and
CONFIG_SC5XX_ROOTFS_OFFSET are left orphaned in Kconfig after this
series. You may want to add a patch to clean those up.

Regards,
Simon


More information about the U-Boot mailing list