[RESEND v4 14/14] arm: sc5xx: Add fdt_addr_r, kernel_addr_r, and initrd_addr

[Simon Glass]

Hi Caleb,

On 2026-04-16T15:19:35, Caleb Ethridge <jcethrid at gmail.com> wrote:
> arm: sc5xx: Add fdt_addr_r, kernel_addr_r, and initrd_addr
>
> Add fdt_addr_r, kernel_addr_r, and initrd_addr to the SC5xx boards,
> to be used by the booti command.
>
> Signed-off-by: Caleb Ethridge <caleb.ethridge at analog.com>
>
> board/adi/sc573-ezlite/sc573-ezlite.env         | 4 ++++
>  board/adi/sc584-ezkit/sc584-ezkit.env           | 4 ++++
>  board/adi/sc589-ezkit/sc589-ezkit.env           | 4 ++++
>  board/adi/sc589-mini/sc589-mini.env             | 4 ++++
>  board/adi/sc594-som-ezkit/sc594-som-ezkit.env   | 4 ++++
>  board/adi/sc594-som-ezlite/sc594-som-ezlite.env | 4 ++++
>  board/adi/sc598-som-ezkit/sc598-som-ezkit.env   | 4 ++++
>  board/adi/sc598-som-ezlite/sc598-som-ezlite.env | 4 ++++
>  8 files changed, 32 insertions(+)

> diff --git a/board/adi/sc594-som-ezlite/sc594-som-ezlite.env b/board/adi/sc594-som-ezlite/sc594-som-ezlite.env
> @@ -3,6 +3,10 @@
> +fdt_addr_r=CONFIG_SYS_LOAD_ADDR
> +kernel_addr_r=0x80008000
> +initrd_addr=0x85000000

The kernel_addr_r value 0x80008000 looks incorrect for this board.
CONFIG_SYS_LOAD_ADDR is a2000000, and sc594-som-ezkit uses
kernel_addr_r=a3008000. I suspect this should be a3008000

Similarly, initrd_addr=85000000 seems inconsistent when the load
address is around Aa000000; sc594-som-ezkit uses A8000000. Please can
you check?

> diff --git a/board/adi/sc573-ezlite/sc573-ezlite.env b/board/adi/sc573-ezlite/sc573-ezlite.env
> @@ -3,6 +3,10 @@
> +initrd_addr=0x85000000

The standard U-Boot naming convention is ramdisk_addr_r - would it
make sense to use that name?

> diff --git a/board/adi/sc573-ezlite/sc573-ezlite.env b/board/adi/sc573-ezlite/sc573-ezlite.env
> @@ -3,6 +3,10 @@
> +fdt_addr_r=CONFIG_SYS_LOAD_ADDR
> +kernel_addr_r=0x84008000
> +initrd_addr=0x85000000

The commit message says these are for booti, but adi_boot.env uses
bootm with fitImage and does not reference these variables. Is this
preparatory work for a future patch? If so, please mention that in the
commit message.

Reviewed-by: Simon Glass <sjg at chromium.org>

Regards,
Simon