[PATCH 2/4] cmd/acpi: add optional index parameter to acpi dump

[Simon Glass]

Hi Heinrich,

On 2026-04-20T22:08:00, Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:
> cmd/acpi: add optional index parameter to acpi dump
>
> Add an optional index parameter defaulting to the acpi dump
> sub-command.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
>
> cmd/acpi.c | 19 +++++++++++++------
>  1 file changed, 13 insertions(+), 6 deletions(-)

> diff --git a/cmd/acpi.c b/cmd/acpi.c
> @@ -12,6 +12,7 @@
> +#include <limits.h>

This include seems to be unused?

> diff --git a/cmd/acpi.c b/cmd/acpi.c
> @@ -183,9 +184,11 @@ static int do_acpi_dump(struct cmd_tbl *cmdtp, int flag, int argc,
> +     char *endp;
> +     ulong idx = 0;

endp is set but never checked. Please either check that the entire
argument was parsed, or use hextoul(argv[2], NULL) and drop endp

Regards,
Simon