[PATCH] common: cli_hush: fix console_buffer overflow on boot retry

[Simon Glass]

Hi,

On Tue, 21 Apr 2026 at 20:06, Rasmus Villemoes <ravi at prevas.dk> wrote:
>
> On Tue, Apr 21 2026, Ngo Luong Thanh Tra <ngotra27101996 at gmail.com> wrote:
>
> > Add const_strcpy() macro to linux/build_bug.h that enforces at
> > compile time that the destination is a writable char array (not char *
> > or const char *), the source is a string literal, and the source fits
> > in the destination including the NUL terminator.
> >
> > Fix the console_buffer extern declaration in console.h to include the
> > array size so sizeof(console_buffer) is valid at call sites.
> >
> > Replace unbounded strcpy() in cli_hush.c with const_strcpy().
> >
> > Fixes: 657e19f8f2dd ("cli_hush: support running bootcmd on boot retry")
> >
> > Changes in v4:
> > - Rebased on top of current master (as requested by Tom Rini)
> >
> > Changes in v3:
> > - Reject const char * destinations in const_strcpy() (Simon Glass)
> >
> > Signed-off-by: Ngo Luong Thanh Tra <S4210155 at student.rmit.edu.au>
> > ---
>
>
> Hi Ngo
>
> Please address the feedback I gave in
> https://lore.kernel.org/u-boot/87zf3co6pz.fsf@prevas.dk/.
>
> Also, two things on creating patches:
>
> When you create a new version of a patch (or patch series), please use
> "git format-patch -vX" where X is the version number. For the next one
> that would be "-v5". Then git will use the subject prefix "[PATCH v5]"
> instead of merely "[PATCH]", making it easier to distinguish the
> different ones in one's inbox or on lore.kernel.org/u-boot.
>
> Second, the informative "Changes in vX:" stuff should go below the ---,
> as it is not part of the commit message and should not be part of the
> permanent git history once the patch is accepted.

You can also use patman which lets you add a 'Series-version: 5' line
in the commit and handles putting the change log in the right place.

Regards,
Simon