回复: [PATCH v1 1/2] net: phy: aquantia: Increase timeout for out of reset

[Alice Guo (OSS)]

> -----邮件原件-----
> 发件人: Tim Harvey <tharvey at gateworks.com>
> 发送时间: 2026年4月21日 23:45
> 收件人: Alice Guo (OSS) <alice.guo at oss.nxp.com>
> 抄送: u-boot at lists.denx.de; Marek Vasut <marex at nabladev.com>; Jerome
> Forissier <jerome.forissier at arm.com>; Tom Rini <trini at konsulko.com>; Beiyan
> Yun <root at infi.wang>; Bo-Cun Chen <bc-bocun.chen at mediatek.com>;
> Siddharth Vadapalli <s-vadapalli at ti.com>; Weijie Gao
> <weijie.gao at mediatek.com>; Ye Li <ye.li at nxp.com>; Vladimir Oltean
> <vladimir.oltean at nxp.com>; Michael Walle <mwalle at kernel.org>; Thomas
> Schäfer <thomas.schaefer at kontron.com>; Marek Vasut <marex at denx.de>;
> Alice Guo <alice.guo at nxp.com>
> 主题: Re: [PATCH v1 1/2] net: phy: aquantia: Increase timeout for out of reset
> 
> On Wed, Apr 15, 2026 at 1:54 AM <alice.guo at oss.nxp.com> wrote:
> >
> > From: Ye Li <ye.li at nxp.com>
> >
> > Current timeout for PHY out of reset is 50ms which is too short.
> > Increase it to 2s to align with kernel.
> >
> > Signed-off-by: Ye Li <ye.li at nxp.com>
> > Signed-off-by: Alice Guo <alice.guo at nxp.com>
> > ---
> >  drivers/net/phy/aquantia.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/phy/aquantia.c b/drivers/net/phy/aquantia.c
> > index 10b87dfb8ab..83da3e1cc77 100644
> > --- a/drivers/net/phy/aquantia.c
> > +++ b/drivers/net/phy/aquantia.c
> > @@ -400,7 +400,7 @@ int aquantia_config(struct phy_device *phydev)
> >         int interface = phydev->interface;
> >         u32 val, id, rstatus, fault;
> >         u32 reg_val1 = 0;
> > -       int num_retries = 5;
> > +       int num_retries = 200;
> >         int usx_an = 0;
> >
> >         /*
> >
> > --
> > 2.34.1
> >
> 
> Hi Alice,
> 
> I ran into this as well on a new board I'm bringing up. I found I needed 100
> retries in my situation.
> 
> Acked-by: Tim Harvey <tharvey at gateworks.com>
> 
> Best Regards,
> 
> Tim

Hi Tim,

Thanks for confirming and for the Ack. I prefer to keep the current retry count for now.

Best regards,
Alice