[PATCH v4] Improve handoff prepare on SoCFPGA

[Chee, Tien Fong]

Hi Brian,

On 22/4/2026 11:13 am, Sune Brian wrote:
> [CAUTION: This email is from outside your organization. Unless you trust the sender, do not click on links or open attachments as it may be a fraudulent email attempting to steal your information and/or compromise your computer.]
>
> On Wed, Apr 22, 2026 at 10:54 AM Simon Glass <sjg at chromium.org> wrote:
>> Hi Brian,
>>
>> On 2026-04-21T00:47:19, Sune Brian <briansune at gmail.com> wrote:
>>> Improve handoff prepare on SoCFPGA
>>>
>>> There are some cases that the Python scripts
>>> are run and the qts files are not replaced.
>>>
>>> This patch introduces:
>>> 1) TMP folder for Python script
>>> 2) TMP folder will automatically remove on exit
>>> 3) If PY script fails, the replace will not conduct.
>>> 4) Only when PY script passed the replace with keep
>>> or without keep will be done via NEW HANDOFF_KEEP=xxx
>>> 5) When keep is selected the old files are renamed to
>>> xxx.h.handoff.<timestamp>
>>>
>>> As such this ensure qts folder h files are properly
>>> updated.
>>>
>>> Signed-off-by: Brian Sune <briansune at gmail.com>
>>>
>>> arch/arm/mach-socfpga/config.mk | 27 ++++++++++++++++++++++++---
>>>   1 file changed, 24 insertions(+), 3 deletions(-)
>> Reviewed-by: Simon Glass <sjg at chromium.org>


Reviewed-by: Tien Fong Chee <tien.fong.chee at altera.com>


Please roll a v5 with:
1) Commit message: imperative tense, add a short v5 changelog vs v4,
    spell out "Python", and fix the backup filename in the text to match
    the code (.h.handoff_backup.<timestamp>).


2) HANDOFF_KEEP: I am fine keeping your current semantics [OR: please
    adopt Simon's single test ...]. Either way, add a brief comment in
    config.mk next to the recipe stating: unset => remove old headers;
    HANDOFF_KEEP set and not 0 => rename old *.h to *.h.handoff_backup.*;
    HANDOFF_KEEP=0 => remove old headers even when the variable is set.


3) [Optional] If HANDOFF_KEEP= (empty) should not mean "keep", adjust the
    shell logic or document the current behavior.


With that I can apply from list.


Thanks.

Best regards,

Tien Fong