[PATCH v1 7/8] arch: arm: dts: n5x : Switch to using upstream Linux DT config

[Lok, Chen Huei]

Hi Tien Fong,

>> +
>> +&flash0 {
>> +	#address-cells = <1>;
>> +	#size-cells = <1>;
>> +	compatible = "jedec,spi-nor";
>
>
> upstream DTS has this compatible defined, so the overrides is redundant.
>
>
I will drop the redundant "compatible" override for
&flash0 in v2.
>> diff --git a/arch/arm/dts/socfpga_n5x_socdk-u-boot.dtsi b/arch/arm/dts/socfpga_n5x_socdk-u-boot.dtsi
>> index bc2fb91dfb5..f013ed49cd3 100644
>> --- a/arch/arm/dts/socfpga_n5x_socdk-u-boot.dtsi
>> +++ b/arch/arm/dts/socfpga_n5x_socdk-u-boot.dtsi
>> @@ -8,12 +8,11 @@
>>   #include "socfpga_n5x-u-boot.dtsi"
>>
>>   /{
>> -	aliases {
>> -		spi0 = &qspi;
>> -		i2c0 = &i2c1;
>> +	chosen {
>> +		u-boot,spl-boot-order = &mmc;
>>   	};
>>
>> -	memory {
>> +	memory at 0 {
>>   		/*
>>   		 * Memory type: DDR4 (non-interleaving mode)
>>   		 * 16GB
>> @@ -38,10 +37,21 @@
>>   };
>>
>>   &flash0 {
>> -	compatible = "jedec,spi-nor";
>> +	reg = <0>;
>>   	spi-tx-bus-width = <4>;
>>   	spi-rx-bus-width = <4>;
>> +	spi-max-frequency = <100000000>;
>>   	bootph-all;
>> +
>> +	m25p,fast-read;
>> +	cdns,page-size = <256>;
>> +	cdns,block-size = <16>;
>> +	cdns,read-delay = <1>;
>> +	cdns,tshsl-ns = <50>;
>> +	cdns,tsd2d-ns = <50>;
>> +	cdns,tchsh-ns = <4>;
>> +	cdns,tslch-ns = <4>;
>> +	/delete-property/ cdns,read-delay;
>
>
> This is contradictory. Setting a property and then deleting it in the 
> same board overlay is nonsensical.
>
> The intent is unclear, if read-delay should not be set, don't add it; 
> if it should be set, don't delete it.
>
>
Agreed. I will remove the unnecessary addition of "cdns,read-delay = 
<1>;" and
keep the node consistent in v2.


Best regards,

Lok