[PATCH v3] drivers: fpga: Use SOC64 conditional instead of Agilex/Stratix10

Lok, Chen Huei chen.huei.lok at altera.com
Tue Apr 28 07:20:40 CEST 2026


Hi Tien Fong,

>>
>> -#if IS_ENABLED(CONFIG_ARCH_SOCFPGA_AGILEX) || \
>> -    IS_ENABLED(CONFIG_ARCH_SOCFPGA_STRATIX10)
>> +#if IS_ENABLED(CONFIG_ARCH_SOCFPGA_SOC64)
>
>
> The guard is now CONFIG_ARCH_SOCFPGA_SOC64, but N5X is SOC64 yet does 
> not select FPGA_INTEL_SDM_MAILBOX (confirmed from Kconfig).
>
> So the comment says "SDM Mailbox based devices" but the guard now also 
> covers N5X which is not SDM Mailbox based.
>
> An alternative guard that is more semantically precise would be:
>
> #if IS_ENABLED(CONFIG_FPGA_INTEL_SDM_MAILBOX)
>
> What do you think?
>
>
CONFIG_FPGA_INTEL_SDM_MAILBOX is the more precise guard here.

The functions being protected (fpga_is_partial_data and 
fpga_loadbitstream) are specifically for SDM Mailbox based devices,

as the comment inside already states, and N5X does not select 
FPGA_INTEL_SDM_MAILBOX despite being SOC64.

I'll send a v4 with that fix.

Thanks.


best regards,

Lok



More information about the U-Boot mailing list