[PATCH 2/2] cmd: ufetch: only show comma separator if there was a previous feature

Quentin Schulz foss+uboot at 0leil.net
Tue Apr 28 12:56:05 CEST 2026


From: Quentin Schulz <quentin.schulz at cherry.de>

Currently, if NET is disabled, the next feature to be printed will start
with a comma and a space which is not pretty. Add the comma and
whitespace only when a previous feature has already been shown.

Signed-off-by: Quentin Schulz <quentin.schulz at cherry.de>
---
 cmd/ufetch.c | 29 ++++++++++++++++++++---------
 1 file changed, 20 insertions(+), 9 deletions(-)

diff --git a/cmd/ufetch.c b/cmd/ufetch.c
index bc5db08eee1..5c0d09c07bf 100644
--- a/cmd/ufetch.c
+++ b/cmd/ufetch.c
@@ -157,26 +157,37 @@ static int do_ufetch(struct cmd_tbl *cmdtp, int flag, int argc,
 				printf(" (%d baud)", gd->baudrate);
 			putc('\n');
 			break;
-		case FEATURES:
+		case FEATURES: {
+			bool sep = false;
+
 			printf("Features:" RESET " ");
-			if (IS_ENABLED(CONFIG_NET))
-				printf("Net");
-			if (IS_ENABLED(CONFIG_EFI_LOADER))
-				printf(", EFI");
-			if (IS_ENABLED(CONFIG_CMD_CAT))
-				printf(", cat :3");
+			if (IS_ENABLED(CONFIG_NET)) {
+				printf("%sNet", sep ? ", " : "");
+				sep = true;
+			}
+			if (IS_ENABLED(CONFIG_EFI_LOADER)) {
+				printf("%sEFI", sep ? ", " : "");
+				sep = true;
+			}
+			if (IS_ENABLED(CONFIG_CMD_CAT)) {
+				printf(":%scat :3", sep ? ", " : "");
+				sep = true;
+			}
 #ifdef CONFIG_ARM64
 			switch (current_el()) {
 			case 2:
-				printf(", VMs");
+				printf("%sVMs", sep ? ", " : "");
+				sep = true;
 				break;
 			case 3:
-				printf(", full control!");
+				printf("%sfull control!", sep ? ", " : "");
+				sep = true;
 				break;
 			}
 #endif
 			printf("\n");
 			break;
+		}
 		case RELOCATION:
 			if (gd->flags & GD_FLG_SKIP_RELOC)
 				printf("Relocated:" RESET " no\n");

-- 
2.54.0



More information about the U-Boot mailing list