[PATCH 06/12] corstone1000: enable bootefi selftest

[Simon Glass]

Hi Harsimran,

On 2026-04-24T17:31:50, Harsimran Singh Tungal
<harsimransingh.tungal at arm.com> wrote:
> corstone1000: enable bootefi selftest
>
> Enable UEFI selftest command in Corstone-1000 defconfig
>
> Turn on CONFIG_CMD_BOOTEFI_SELFTEST in the Corstone-1000 defconfig
> so the board can run the built-in UEFI self-test suite during
> development and validation.
>
> Signed-off-by: Harsimran Singh Tungal <harsimransingh.tungal at arm.com>
>
> configs/corstone1000_defconfig | 3 +++
>  1 file changed, 3 insertions(+)

> diff --git a/configs/corstone1000_defconfig b/configs/corstone1000_defconfig
> @@ -63,6 +65,7 @@ CONFIG_SYSRESET=y
>  CONFIG_SYSRESET_PSCI=y
>  CONFIG_TEE=y
>  CONFIG_OPTEE=y
> +# CONFIG_CMD_POWEROFF is not set
>  CONFIG_USB=y

Why is this disabled? It's not mentioned in the commit message and
looks unrelated to enabling the bootefi selftest. If it's a stray
byproduct of 'make savedefconfig' please drop it; if intentional it
should be a separate patch with its own justification.

> diff --git a/configs/corstone1000_defconfig b/configs/corstone1000_defconfig
> @@ -32,6 +32,8 @@ CONFIG_SYS_PROMPT="corstone1000# "
>  # CONFIG_CMD_CONSOLE is not set
>  CONFIG_CMD_FWU_METADATA=y
>  CONFIG_CMD_BOOTZ=y
> +# CONFIG_CMD_BOOTEFI_HELLO is not set
> +CONFIG_CMD_BOOTEFI_SELFTEST=y

The commit message says only that selftest is being enabled, but
you're also explicitly disabling CMD_BOOTEFI_HELLO (which would
otherwise default to y once SELFTEST is set). Please mention this, and
ideally state the real motivation - that this is needed so patch 7 of
the series can run the runtime variable selftest on this board, right?

> Enable UEFI selftest command in Corstone-1000 defconfig

>
> Turn on CONFIG_CMD_BOOTEFI_SELFTEST in the Corstone-1000 defconfig
> so the board can run the built-in UEFI self-test suite during
> development and validation.

The first paragraph just restates the subject. Please drop it and keep
the second paragraph, which actually explains the change. Referencing
the runtime-variable selftest added later in the series would also
help, since that is the real reason for enabling it now.

Regards,
Simon