[v2,0/4] fastboot: block: Add GPT/MBR and device selection

Simon Glass sjg at chromium.org
Tue Apr 28 20:23:42 CEST 2026


Hi Balaji,

On 2026-04-27T12:06:41, Balaji Selvanathan
<balaji.selvanathan at oss.qualcomm.com> wrote:

> Patch 2 adds fastboot_flash_gpt_partition_table() and
> fastboot_flash_mbr_partition_table() helper functions that handle
> flashing of GPT and MBR partition tables to block devices.

Patch 2 also refactors fb_mmc.c to use the new helpers — please
mention the MMC conversion here in v3.

> Patch 1 implements device selection syntax allowing users to specify the
> target block device using 'N:partition' format

Since you are adding a new feature (the N:partition parser, plus
GPT/MBR flashing on the block backend), please add test coverage. See
test/dm/fastboot.c which already exercises
fastboot_mmc_get_part_info() - you can add cases there for the block
path: a successful '0:foo' parse, the bare 'foo' fallback to the
default device, and rejection of a leading-colon name like ':gpt'.
Otherwise the parser and is_partition_table_name() interaction are
easy to break in future refactors.

BTW the v2 changelog has 'Seperate' (twice) and 'fot' - please tidy this up.

Regards,
Simon


More information about the U-Boot mailing list