[PATCH v2 1/6] pinctrl: add missed pinconf/pinctrl definitions

[David Lechner]

In the subject, I would say "more" instead of "missed".


On 4/28/26 10:34 AM, Mikhail Kshevetskiy wrote:
> The code was taken from linux-7.0

The commit message should also explain why we need these changes
in U-Boot.

And in this case an explanation of why you chose the locations
for the code would be helpful.

Since the code is taken from Linux, it is odd that some goes in
a U-Boot dm/ header while the other goes in a linux/ header.

The patch itself seems OK to me, but I wouldn't mind hearing from
someone who has been working on U-Boot more than me to say what best
practices are on copying code from Linux.