[PATCH 2/3] i2c: designware_i2c: Remove clk disabled codes

[Heiko Schocher]

Hello Dinesh,

On 29.04.26 07:11, dinesh.maniyam at altera.com wrote:
> From: Dinesh Maniyam <dinesh.maniyam at altera.com>
> 
> l4_sp_clk is disabled when i2c device is removed, this would
> causing unexpected failing behavior for other peripherals which
> are still running with l4_sp_clk. The patch removes the codes
> implementation for disabling the lp_spl_clk.
> 
> Signed-off-by: Tien Fong Chee <tien.fong.chee at altera.com>
> Signed-off-by: Dinesh Maniyam <dinesh.maniyam at altera.com>
> ---
>   drivers/i2c/designware_i2c.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/i2c/designware_i2c.c b/drivers/i2c/designware_i2c.c
> index 8ad716f410e..40153c72545 100644
> --- a/drivers/i2c/designware_i2c.c
> +++ b/drivers/i2c/designware_i2c.c
> @@ -807,10 +807,6 @@ int designware_i2c_remove(struct udevice *dev)
>   {
>   	struct dw_i2c *priv = dev_get_priv(dev);
>   
> -#if CONFIG_IS_ENABLED(CLK)
> -	clk_disable(&priv->clk);
> -#endif

Hmm... clock framework should have a counter how many times clock
is enabled... with your patch, clock never gets disabled...

bye,
Heiko
> -
>   	return reset_release_bulk(&priv->resets);
>   }
>   
> 

-- 
Nabla Software Engineering
HRB 40522 Augsburg
Phone: +49 821 45592596
E-Mail: office at nabladev.com
Geschäftsführer : Stefano Babic