[PATCH] video: stm32: dsi: fix unchecked return values

[Patrice CHOTARD]

On 4/12/26 21:07, Raphael Gallais-Pou wrote:
> Fix the following errors yielded by Coverity Scan:
> 
> CID 644836:         Error handling issues  (CHECKED_RETURN)
> Calling device_chld_unbind without checking return value (as is done elsewhere 6 out of 7 times)
> CID 644834:         Error handling issues  (CHECKED_RETURN)
> Calling device_chld_remove without checking return value (as is done elsewhere 4 out of 5 times).
> 
> Link: https://lore.kernel.org/r/20260309212331.GF1388590@bill-the-cat/
> Fixes: a6d047c0a86b ("video: stm32: remove all child of DSI bridge when its probe failed")
> 
> Signed-off-by: Raphael Gallais-Pou <rgallaispou at gmail.com>
> ---
>  drivers/video/stm32/stm32_dsi.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/stm32/stm32_dsi.c b/drivers/video/stm32/stm32_dsi.c
> index 65a91f5cff7a..5c4d8d2aab51 100644
> --- a/drivers/video/stm32/stm32_dsi.c
> +++ b/drivers/video/stm32/stm32_dsi.c
> @@ -493,8 +493,11 @@ static int stm32_dsi_probe(struct udevice *dev)
>  	    priv->hw_version != HWVER_131) {
>  		dev_err(dev, "DSI version 0x%x not supported\n", priv->hw_version);
>  		dev_dbg(dev, "remove and unbind all DSI child\n");
> -		device_chld_remove(dev, NULL, DM_REMOVE_NORMAL);
> -		device_chld_unbind(dev, NULL);
> +		ret = device_chld_remove(dev, NULL, DM_REMOVE_NORMAL);
> +		if (!ret)
> +			ret = device_chld_unbind(dev, NULL);
> +		if (ret)
> +			dev_err(dev, "Unbinding from %s failed %d\n", dev->name, ret);
>  		ret = -ENODEV;
>  		goto err_clk;
>  	}
> 
> ---
> base-commit: e2fa3e570f83ab0f9ce667ddaec9dc738bcf05b9
> change-id: 20260412-master-8be67866e096
> 
> Best regards,
> --  
> Raphael Gallais-Pou <rgallaispou at gmail.com>
> 

Hi Raphael

Reviewed-by: Patrice Chotard <patrice.chotard at foss.st.com>

Thanks
Patrice