[PATCH] fdt: check fdt_pack() return value in fdtdec_apply_bloblist_dtos()
Sverdlin, Alexander
alexander.sverdlin at siemens.com
Wed Apr 29 10:26:28 CEST 2026
Hi Michal!
On Wed, 2026-04-29 at 08:22 +0200, Michal Simek wrote:
> The fdt_pack() function can return an error code, but its return value
> was not being checked. Add proper error handling to propagate any
> failure.
>
> Also fix typo in comment: "Shink" -> "Shrink".
>
> Addresses-Coverity-ID: CID 645839: Error handling issues (CHECKED_RETURN)
> Signed-off-by: Michal Simek <michal.simek at amd.com>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin at siemens.com>
> ---
>
> lib/fdtdec.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/lib/fdtdec.c b/lib/fdtdec.c
> index c6e13b6abefd..2d66860f6ed0 100644
> --- a/lib/fdtdec.c
> +++ b/lib/fdtdec.c
> @@ -1781,8 +1781,11 @@ static int fdtdec_apply_bloblist_dtos(void)
> if (ret)
> return ret;
>
> - /* Shink the blob to the actual FDT size */
> - fdt_pack(live_fdt);
> + /* Shrink the blob to the actual FDT size */
> + ret = fdt_pack(live_fdt);
> + if (ret)
> + return ret;
> +
> return bloblist_resize(BLOBLISTT_CONTROL_FDT, fdt_totalsize(live_fdt));
> }
>
--
Alexander Sverdlin
Siemens AG
www.siemens.com
More information about the U-Boot
mailing list