[PATCH v5 02/15] mach-sc5xx: Remove update commands from default environment

[Simon Glass]

Hi Caleb,

On 2026-04-23T14:24:50, Caleb Ethridge <jcethrid at gmail.com> wrote:
> mach-sc5xx: Remove update commands from default environment
>
> Remove the update_spi family of commands from the U-boot
> environment. These commands are not standard in U-boot,
> and boot media programming has moved to Linux, so the
> commands can be safely removed.
>
> Signed-off-by: Caleb Ethridge <caleb.ethridge at analog.com>
>
> board/adi/sc573-ezkit/sc573-ezkit.env           |  2 -
>  board/adi/sc584-ezkit/sc584-ezkit.env           |  2 -
>  board/adi/sc589-ezkit/sc589-ezkit.env           |  2 -
>  board/adi/sc589-mini/sc589-mini.env             |  2 -
>  board/adi/sc594-som-ezkit/sc594-som-ezkit.env   |  2 -
>  board/adi/sc594-som-ezlite/sc594-som-ezlite.env |  2 -
>  board/adi/sc598-som-ezkit/sc598-som-ezkit.env   |  2 -
>  board/adi/sc598-som-ezlite/sc598-som-ezlite.env |  2 -
>  configs/sc573-ezkit_defconfig                   |  2 -
>  configs/sc584-ezkit_defconfig                   |  2 -
>  configs/sc589-ezkit_defconfig                   |  2 -
>  configs/sc589-mini_defconfig                    |  2 -
>  include/env/adi/adi_boot.env                    | 53 -------------------------
>  13 files changed, 77 deletions(-)

> diff --git a/include/env/adi/adi_boot.env b/include/env/adi/adi_boot.env
> @@ -1,9 +1,7 @@
>  /*
>   * A target board needs to set these variables for the commands below to work:
>   *
> - * - adi_stage2_offset, the location of stage2-boot.ldr on the SPI flash
>   * - adi_image_offset, location of the fitImage on the SPI flash
> - * - adi_rfs_offset, location of the RFS on the SPI flash
>   * - loadaddr, where you want to load things
>   * - jffs2file, name of the jffs2 file for update, ex adsp-sc5xx-tiny-adsp-sc573.jffs2
>   */

The jffs2file bullet should go too, right? - its only consumer is
update_spi_rfs, which this patch removes. Also the jffs2file= lines in
each board's *.env could be dropped

> diff --git a/configs/sc573-ezkit_defconfig b/configs/sc573-ezkit_defconfig
> @@ -6,9 +6,7 @@ CONFIG_SPL_GPIO=y
>  CONFIG_DM_GPIO=y
>  CONFIG_SPL_SYS_MALLOC_F_LEN=0x10000
>  CONFIG_SPL_SERIAL=y
> -CONFIG_SC5XX_UBOOT_OFFSET=0x20000
>  CONFIG_SC5XX_FITIMAGE_OFFSET=0xE0000
> -CONFIG_SC5XX_ROOTFS_OFFSET=0x6E0000

The commit message only mentions the update_spi commands, but the
patch also strips
adi_stage2_offset/adi_rfs_offset/imagefile/init_ethernet from the env
and removes CONFIG_SC5XX_UBOOT_OFFSET/CONFIG_SC5XX_ROOTFS_OFFSET from
the defconfigs. Please can you expand the message to cover this, or
perhaps split the patches.

Note that it should be wrttten as 'U-Boot'

Regards,
Simon