[PATCH v5 05/15] mach-sc5xx: Add USB boot command

[Simon Glass]

Hi Caleb,

On 2026-04-23T14:24:50, Caleb Ethridge <jcethrid at gmail.com> wrote:
> mach-sc5xx: Add USB boot command
>
> Add the USB boot command to the environments
> of the boards that support it.
>
> Signed-off-by: Caleb Ethridge <caleb.ethridge at analog.com>
>
> board/adi/sc573-ezkit/sc573-ezkit.env           | 1 +
>  board/adi/sc584-ezkit/sc584-ezkit.env           | 1 +
>  board/adi/sc589-ezkit/sc589-ezkit.env           | 1 +
>  board/adi/sc589-mini/sc589-mini.env             | 1 +
>  board/adi/sc594-som-ezkit/sc594-som-ezkit.env   | 1 +
>  board/adi/sc594-som-ezlite/sc594-som-ezlite.env | 1 +
>  board/adi/sc598-som-ezkit/sc598-som-ezkit.env   | 1 +
>  include/env/adi/adi_boot.env                    | 7 +++++++
>  8 files changed, 14 insertions(+)

Reviewed-by: Simon Glass <sjg at chromium.org>

> diff --git a/include/env/adi/adi_boot.env b/include/env/adi/adi_boot.env
> @@ -68,3 +68,10 @@ ramboot= wget ${loadaddr} ${serverip}:/fitImage;
> +#if defined(USE_USB)
> +usbargs=setenv bootargs root=/dev/sda2 rw rootfstype=ext4 rootwait ${adi_bootargs}
> +usbboot=usb start;
> +     ext4load usb 0:1 ${loadaddr} /fitImage; run usbargs;
> +     bootm ${loadaddr}
> +#endif

Please split ext4load and run usbargs onto separate lines, to match
the style of mmcboot/spiboot/ospiboot above.

Just to check...should the partition for the fitImage match the rootfs
convention used by mmcboot (load from p1, root on p2)? You have 'usb
0:1' for the load and sda2 for root, which mirrors the mmc case, so I
think this is intentional - but worth confirming a freshly-imaged USB
stick is partitioned that way by the build.

Regards,
Simon