[PATCH v5 14/15] arm: sc5xx: Add fdt_addr_r, kernel_addr_r, and ramdisk_addr_r

[Simon Glass]

Hi Caleb,

On 2026-04-23T14:24:50, Caleb Ethridge <jcethrid at gmail.com> wrote:
> arm: sc5xx: Add fdt_addr_r, kernel_addr_r, and ramdisk_addr_r
>
> Add fdt_addr_r, kernel_addr_r, and ramdisk_addr_r to the SC5xx boards.
> These variables are currently unused in the environment but will be
> used in the future once support for booti commands is added to the
> SC5xx boards.
>
> Signed-off-by: Caleb Ethridge <caleb.ethridge at analog.com>
>
> board/adi/sc573-ezlite/sc573-ezlite.env         | 4 ++++
>  board/adi/sc584-ezkit/sc584-ezkit.env           | 4 ++++
>  board/adi/sc589-ezkit/sc589-ezkit.env           | 4 ++++
>  board/adi/sc589-mini/sc589-mini.env             | 4 ++++
>  board/adi/sc594-som-ezkit/sc594-som-ezkit.env   | 4 ++++
>  board/adi/sc594-som-ezlite/sc594-som-ezlite.env | 4 ++++
>  board/adi/sc598-som-ezkit/sc598-som-ezkit.env   | 4 ++++
>  board/adi/sc598-som-ezlite/sc598-som-ezlite.env | 4 ++++
>  8 files changed, 32 insertions(+)

> diff --git a/board/adi/sc573-ezlite/sc573-ezlite.env b/board/adi/sc573-ezlite/sc573-ezlite.env
> @@ -3,6 +3,10 @@
> +fdt_addr_r=CONFIG_SYS_LOAD_ADDR
> +kernel_addr_r=0x84008000
> +ramdisk_addr_r=0x85000000

fdt_addr_r resolves to the same address as loadaddr (which also
defaults to CONFIG_SYS_LOAD_ADDR and is what the existing FIT-based
boot scripts in adi_boot.env load to). When booti support lands,
loading a kernel image to ${loadaddr} and an FDT to ${fdt_addr_r}
would overwrite each other. How about picking a distinct value now so
the future booti patch doesn't have to touch every board file again?

> diff --git a/board/adi/sc584-ezkit/sc584-ezkit.env b/board/adi/sc584-ezkit/sc584-ezkit.env
> @@ -3,6 +3,10 @@
> +fdt_addr_r=CONFIG_SYS_LOAD_ADDR
> +kernel_addr_r=0x8A308000
> +ramdisk_addr_r=0x8A800000

Please use lower-case hex. The gap between kernel_addr_r and
ramdisk_addr_r here is only 0x4f8000 (~5 MiB), which is tight for a
typical ARM kernel. The other 32-bit boards in this patch leave ~16
MiB. Is that intentional?

Regards,
Simon