[PATCH v4 09/11] arm: dts: k3-{j721s2/j722s/j784s4}-r5.dtsi: Enable HSM core

[Simon Glass]

Hi Beleswar,

On 2026-04-25T03:37:39, Padhi, Beleswar <b-padhi at ti.com> wrote:
> arm: dts: k3-{j721s2/j722s/j784s4}-r5.dtsi: Enable HSM core
>
> The HSM M4F node is disabled by default in the device tree. Enable the
> node here as we have to load and boot the core in R5 SPL stage. Assign
> the alias of 'remoteproc2' to the hsm node. This assigns the sequence
> number '2' to HSM core which can be used during rproc_load() and
> rproc_start() calls.
>
> Signed-off-by: Beleswar Padhi <b-padhi at ti.com>
>
> arch/arm/dts/k3-j721s2-r5.dtsi | 5 +++++
>  arch/arm/dts/k3-j722s-r5.dtsi  | 5 +++++
>  arch/arm/dts/k3-j784s4-r5.dtsi | 4 ++++
>  3 files changed, 14 insertions(+)

> diff --git a/arch/arm/dts/k3-j721s2-r5.dtsi b/arch/arm/dts/k3-j721s2-r5.dtsi
> @@ -102,3 +103,7 @@
> +&hsm {
> +     status = 'okay';
> +};

Does this have or need bootph-pre-ram here so that the node is present in SPL?

> diff --git a/arch/arm/dts/k3-j721s2-r5.dtsi b/arch/arm/dts/k3-j721s2-r5.dtsi
> @@ -11,6 +11,7 @@
>       aliases {
>               remoteproc0 = &sysctrler;
>               remoteproc1 = &a72_0;
> +             remoteproc2 = &hsm;
>       };

Hard-coding sequence 2 in the alias and then using a literal '2' in
jump_to_image() (patch 11) is not great - anyone adding a remoteproc
later, or building without HSM enabled on a board that adds another
rproc, will quietly shift the index. Can you look it up by compatible
or phandle in the caller, or at least add a comment in both this file
and arch/arm/mach-k3/r5/common.c explaining this connection.

Reviewed-by: Simon Glass <sjg at chromium.org>

Regards,
Simon