[PATCH v4 0/3] rockchip: Add initial RK3582 support

[Jonas Karlman]

Hi Quentin,

On 1/15/2026 11:34 AM, Quentin Schulz wrote:
> Hi Jonas,
> 
> On 1/8/26 12:07 AM, Jonas Karlman wrote:
>> This series add initial support for RK3582 support. The RK3582 is a
>> variant of the RK3588S with a few ip blocks disabled. What blocks are
>> disabled/non-working is indicated by the ip-state in OTP.
>>
>> Compared to the vendor U-Boot variant, this mark cpu, the gpu and
>> vdec/venc with status=fail instead of removing nodes during DT fixup.
>> Linux skip cpu cores marked as failed staring from v5.17-rc1, however
>> the GIC driver will generate a harmless WARN_ON that safely can be
>> ignored. A patch for Linux will be sent to skip the WARN_ON for
>> failed/disabled cpu cores once this lands.
>>
>> It is recommended to use rk3588_ddr_lp4_1848MHz_lp5_2112MHz_v1.19.bin
>> as DRAM init blob RK3582, listed in latest RKBOOT/RK3582MINIALL.ini.
>>
> 
> As opposed to what?

The release note for rk3588 rkbin blobs [1] list this DRAM init blob
version with:

  New
  - Add RK3582 support.

So this remark was a hint that users should use a DRAM init blob that
has proper support for RK3582 when testing this series.

[1] https://github.com/rockchip-linux/rkbin/blob/master/doc/release/RK3588_EN.md

> I see there are 2 DDR bin and 2 eyescan DDR bin in rkbin, but I'm 
> assuming at some point there'll be a newer release so we need to know 
> which to use.
> 
> I'm assuming what matters is to match what's inside 
> RKBOOT/RK3582MINIALL.ini? Can you add this to 
> doc/board/rockchip/rockchip.rst maybe?

That is something that is true for all SoCs using BL31 or ROCKCHIP_TPL
blobs from rkbin repo and a topic I think is better suited for a
separate documentation improvement series.

Something like following could possible be added.

  When BL31 and ROCKCHIP_TPL blobs from rkbin is used it is recommended to select
  the blob referenced in RKTRUST/<soc>TRUST.ini and RKBOOT/<soc>MINIALL.ini.

  Something like following can be used to set the environment variables:

  .. code-block:: bash

        export BL31=../rkbin/$(confget -f ../rkbin/RKTRUST/<soc>TRUST.ini -s BL31_OPTION PATH)
        export ROCKCHIP_TPL=../rkbin/$(confget -f ../rkbin/RKBOOT/<soc>MINIALL.ini -s LOADER_OPTION FlashData)

That is similar to what I use in my build scripts :-)

For this series I will however include something like below in a v5.

diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst
index 217694de0c92..022f8f2f20c0 100644
--- a/doc/board/rockchip/rockchip.rst
+++ b/doc/board/rockchip/rockchip.rst
@@ -329,13 +329,15 @@ To build rk3576 boards:
         make roc-pc-rk3576_defconfig
         make CROSS_COMPILE=aarch64-linux-gnu-

-To build rk3588 boards:
+To build rk3588 (or rk3582) boards:

 .. code-block:: bash

-        export BL31=../rkbin/bin/rk35/rk3588_bl31_v1.33.elf
-        export ROCKCHIP_TPL=../rkbin/bin/rk35/rk3588_ddr_lp4_2112MHz_lp5_2736MHz_v1.09.bin
-        make evb-rk3588_defconfig
+        export BL31=../trusted-firmware-a/build/rk3588/release/bl31/bl31.elf
+        [or]export BL31=../rkbin/bin/rk35/rk3588_bl31_v1.51.elf
+        export ROCKCHIP_TPL=../rkbin/bin/rk35/rk3588_ddr_lp4_2112MHz_lp5_2400MHz_v1.19.bin
+        [or]export ROCKCHIP_TPL=../rkbin/bin/rk35/rk3588_ddr_lp4_1848MHz_lp5_2112MHz_v1.19.bin
+        make generic-rk3588_defconfig
         make CROSS_COMPILE=aarch64-linux-gnu-

 Flashing
---

Regards,
Jonas

> Cheers,
> Quentin