Re: [PATCH] cmd: zip: Use map_sysmem() with buffers in the zip command

[Heinrich Schuchardt]

Am 28. Januar 2026 00:53:23 MEZ schrieb Marek Vasut <marek.vasut+renesas at mailbox.org>:
>The current implementation casts an address to a pointer. Make it more
>sandbox-friendly by using map_sysmem().
>
>Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
>---
>Cc: Alexander Graf <agraf at csgraf.de>
>Cc: Heinrich Schuchardt <xypron.glpk at gmx.de>
>Cc: Ilias Apalodimas <ilias.apalodimas at linaro.org>
>Cc: Jerome Forissier <jerome at forissier.org>
>Cc: Mattijs Korpershoek <mkorpershoek at kernel.org>
>Cc: Neil Armstrong <neil.armstrong at linaro.org>
>Cc: Peng Fan <peng.fan at nxp.com>
>Cc: Quentin Schulz <quentin.schulz at cherry.de>
>Cc: Simon Glass <sjg at chromium.org>
>Cc: Tom Rini <trini at konsulko.com>
>Cc: Yuya Hamamachi <yuya.hamamachi.sx at renesas.com>
>Cc: u-boot at lists.denx.de
>---
> cmd/zip.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/cmd/zip.c b/cmd/zip.c
>index 2d255428822..1712434ba0a 100644
>--- a/cmd/zip.c
>+++ b/cmd/zip.c
>@@ -7,6 +7,7 @@
> #include <command.h>
> #include <env.h>
> #include <gzip.h>
>+#include <mapmem.h>
> #include <vsprintf.h>
> 
> static int do_zip(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
>@@ -27,8 +28,10 @@ static int do_zip(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
> 			return cmd_usage(cmdtp);
> 	}
> 
>-	if (gzip((void *) dst, &dst_len, (void *) src, src_len) != 0)
>+	if (gzip(map_sysmem(dst, dst_len), &dst_len,
>+		 map_sysmem(src, src_len), src_len) != 0) {

Wasn't the idea of map_sysmem() with a non-zero length to have a matching unmap_sysmem()?

@Simon:

Does the sandbox really need the mappped areas or can we get rid of the length parameter and of unmap_sysmem()?

Best regards

Heinrich


> 		return 1;
>+	}
> 
> 	printf("Compressed size: %lu = 0x%lX\n", dst_len, dst_len);
> 	env_set_hex("filesize", dst_len);