[PATCH] cmd: zip: Use map_sysmem() with buffers in the zip command

Marek Vasut marek.vasut at mailbox.org
Wed Jan 28 13:16:51 CET 2026


On 1/28/26 5:53 AM, Heinrich Schuchardt wrote:

Hello Heinrich,

>> static int do_zip(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
>> @@ -27,8 +28,10 @@ static int do_zip(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
>> 			return cmd_usage(cmdtp);
>> 	}
>>
>> -	if (gzip((void *) dst, &dst_len, (void *) src, src_len) != 0)
>> +	if (gzip(map_sysmem(dst, dst_len), &dst_len,
>> +		 map_sysmem(src, src_len), src_len) != 0) {
> 
> Wasn't the idea of map_sysmem() with a non-zero length to have a matching unmap_sysmem()?
> 
> @Simon:
> 
> Does the sandbox really need the mappped areas or can we get rid of the length parameter and of unmap_sysmem()?
> 
> Best regards
Let me add the unmap_sysmem(), also for do_unzip() where it is missing too.


More information about the U-Boot mailing list