[PATCH] video: simplefb: fix rot prop handling

[Casey Connolly]

On 6/1/26 08:05, Sam Day wrote:
> If the simplefb node lacks a rot property (which would be most of them
> nowadays - it's not actually a valid prop according to kernel's
> simple-framebuffer schema), then the rot local is left uninitialized.
> This causes video_post_probe to fail to locate the vidconsoleN device
> later.
> 
> Strangely enough, simplefb has been working fine on arm64 targets. It
> wasn't until I tried simplefb on my arm32 device (samsung-expressltexx)
> that this issue manifested. AFAICT, ARM64 doesn't have something like
> -ftrivial-auto-var-init=zero enabled, so I suspect this has just been
> working entirely by coincidence until now. Computers are fun.
> 
> Fixes: 91e9687b49e7 ("video: simplefb: modernise DT parsing")
> Signed-off-by: Sam Day <me at samcday.com>

Reviewed-by: Casey Connolly <casey.connolly at linaro.org>

> ---
>   drivers/video/simplefb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c
> index 8d0772d4e51..ed8d4170cfc 100644
> --- a/drivers/video/simplefb.c
> +++ b/drivers/video/simplefb.c
> @@ -19,7 +19,7 @@ static int simple_video_probe(struct udevice *dev)
>   	int ret;
>   	fdt_addr_t base;
>   	fdt_size_t size;
> -	u32 width, height, stride, rot;
> +	u32 width, height, stride, rot = 0;
>   
>   	base = dev_read_addr_size(dev, &size);
>   	if (base == FDT_ADDR_T_NONE) {
> 
> ---
> base-commit: 30b77f6aa146c96b831cb4ece038130b655b6a41
> change-id: 20260601-simplefb-rot-fix-7afa95d24118
> 
> Best regards,