[PATCH v3 4/9] arm: socfpga: Update Stratix10 SPL data save and restore implementation

[Yuslaimi, Alif Zakuan]

Hi Tien Fong,

On 3/6/2026 3:17 pm, Chee, Tien Fong wrote:
> Hi Alif,
> 
> 
> On 18/5/2026 9:12 am, alif.zakuan.yuslaimi at altera.com wrote:
>> From: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi at altera.com>
>>
>> Enable backup for data section to support warm reset in Stratix10 SPL as
>> no SPL image would be reloaded in warm reset.
>>
>> Signed-off-by: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi at altera.com>
>> ---
>>
>> (no changes since v1)
>>
>>   arch/arm/mach-socfpga/spl_s10.c     | 17 +++++++++++++++++
>>   configs/socfpga_stratix10_defconfig |  2 +-
>>   2 files changed, 18 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-socfpga/spl_s10.c b/arch/arm/mach-socfpga/ 
>> spl_s10.c
>> index 8ab80740c6e..ce1d5d4c8ff 100644
>> --- a/arch/arm/mach-socfpga/spl_s10.c
>> +++ b/arch/arm/mach-socfpga/spl_s10.c
>> @@ -21,12 +21,29 @@
>>   #include <watchdog.h>
>>   #include <dm/uclass.h>
>> +u32 reset_flag(void)
> 
> 
> spl_save_restore_data() calls reset_flag(cold_reboot_flag). S10 defines 
> reset_flag(void), which is not a proper override of the weak 
> reset_flag(u32 flag) and may break under strict prototypes. Logic 
> matches Agilex5 (0 = warm → restore, 1 = cold → save); only the 
> signature needs fixing.
> 

Thanks for pointing this out, I will fix this in v4.

Regards,
Alif

> 
> Best regards,
> 
> Tien Fong
>