[PATCH v2 6/8] arm: socfpga: n5x: switch firewall setup to driver model
LOK, CHEN HUEI
chen.huei.lok at altera.com
Fri Jun 5 10:57:38 CEST 2026
Hi Tien Fong,
On 28/4/2026 3:00 pm, Tien Fong Chee wrote:
> If firewall_setup() is defined in a separate source file (which is
> implied by the function call existing before this patch),
> removing its only call site should prompt deletion of the function
> definition too.
>
> Without that, the linker may still include the dead code.
>
> The diff should include the removal of the firewall_setup() implementation.
Addressed in v3 — extended this patch to fully remove the
dead code: deleted firewall.c, removed firewall.o from the Makefile,
removed the declaration and unused struct/macro definitions from
firewall.h, and dropped the stale include from spl_n5x.c.
This series depends on Alif's series which removes the last
firewall_setup() call in spl_s10.c — will document this dependency
in the v3 cover letter.
Best regards,
Lok
More information about the U-Boot
mailing list